Refactor tests, credential cache #1102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding @DmitryLukyanov to take first crack at this. Edit: never mind. This is just refactoring, it seems. |
jyemin
requested changes
Apr 3, 2023
driver-core/src/test/unit/com/mongodb/AbstractConnectionStringTest.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/unit/com/mongodb/AuthConnectionStringTest.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/unit/com/mongodb/AuthConnectionStringTest.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/MongoCredentialWithCache.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/MongoCredentialWithCache.java
Outdated
Show resolved
Hide resolved
|
I can't remember whether we intend to merge this or just close it. |
katcharov
force-pushed
the
JAVA-4757-cleanup
branch
from
9ee986c to
ad9b6c2
Compare
katcharov
force-pushed
the
JAVA-4757-cleanup
branch
2 times, most recently
from
5536610 to
d562cb3
Compare
katcharov
force-pushed
the
JAVA-4757-cleanup
branch
from
d562cb3 to
d46f122
Compare
stIncMale
requested changes
May 19, 2023
driver-core/src/test/unit/com/mongodb/AuthConnectionStringTest.java
Outdated
Show resolved
Hide resolved
stIncMale
approved these changes
May 19, 2023
stIncMale
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-4979
Refactoring for:
JAVA-4757